fix(Sisyfos): 'mixerOnline' event was emitted continously - #396
Merged
nytamin merged 1 commit intoSep 9, 2025
Merged
Conversation
…n every ping, which in turn caused the event 'connectionChanged' to be emitted continously. This in turn causes unnecessary load and logging.
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Julusian
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the Contributor
Type of Contribution
This is a: Bug fix
Current Behavior
The
mixerOnlineevent is emitted continuously in the Sisyfos device, which causes a log line to be written continuously.New Behavior
The
mixerOnlineevent is only emitted upon change, logging is reduced.Status